Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

RPC: debug_traceBlockByNumber #555

Merged
merged 30 commits into from
Sep 15, 2021
Merged

RPC: debug_traceBlockByNumber #555

merged 30 commits into from
Sep 15, 2021

Conversation

crypto-facs
Copy link
Contributor

Description

Added debug_traceBlockByNumber JSON RPC endpoint.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@orijbot
Copy link

orijbot commented Sep 13, 2021

Visit https://dashboard.github.orijtech.com?back=0&pr=555&remote=true&repo=crypto-facs%2Fethermint to see benchmark details.

@codecov
Copy link

codecov bot commented Sep 13, 2021 •
edited
Loading

Codecov Report

Merging #555 (181d552) into main (ec7d8a3) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   53.77%   53.78%           
=======================================
  Files          64       64           
  Lines        5281     5282    +1     
=======================================
+ Hits         2840     2841    +1     
  Misses       2307     2307           
  Partials      134      134
Impacted Files Coverage Δ
x/evm/types/tracer.go 0.00% <ø> (ø)
x/evm/keeper/grpc_query.go 68.44% <60.00%> (+0.07%) ⬆️

@lgtm-com
Copy link

lgtm-com bot commented Sep 13, 2021

This pull request introduces 1 alert when merging df5d302 into 5a70dfb - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

fedekunze
fedekunze reviewed Sep 13, 2021
View reviewed changes
ethereum/rpc/backend/backend.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/types.go Outdated Show resolved Hide resolved
@crypto-facs crypto-facs marked this pull request as ready for review September 14, 2021 09:05
fedekunze
fedekunze reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minor comments only. Can you also update the docs and add a CHANGELOG entry?

ethereum/rpc/backend/backend.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/debug/api.go Outdated Show resolved Hide resolved
go.sum Show resolved Hide resolved
x/evm/keeper/grpc_query.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

docs/api/json-rpc/endpoints.md Outdated Show resolved Hide resolved
ethereum/rpc/namespaces/eth/filters/filters.go Outdated Show resolved Hide resolved
@fedekunze fedekunze added automerge Automatically merge PR once all prerequisites pass. C:JSON-RPC JSON-RPC client labels Sep 15, 2021
@fedekunze fedekunze enabled auto-merge (squash) September 15, 2021 08:38
@fedekunze fedekunze merged commit 3f1eeb3 into evmos:main Sep 15, 2021
@lcmmhcc lcmmhcc mentioned this pull request Dec 9, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass. C:JSON-RPC JSON-RPC client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crypto-facs @orijbot @fedekunze